esutil: Modify the BulkIndexerConfig.Client type to esapi.Transport#957
Merged
Anaethelion merged 1 commit intoelastic:mainfrom Apr 17, 2025
Merged
Conversation
|
💚 CLA has been signed |
Anaethelion
approved these changes
Apr 17, 2025
Contributor
Anaethelion
left a comment
Anaethelion
left a comment
There was a problem hiding this comment.
LGTM, thank you for raising this.
This was referenced Apr 17, 2025
Anaethelion
pushed a commit
that referenced
this pull request
Apr 17, 2025
Anaethelion
pushed a commit
that referenced
this pull request
Apr 17, 2025
Anaethelion
pushed a commit
that referenced
this pull request
Apr 17, 2025
This was referenced Apr 17, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, when using a pre-declared
TypedClient, a separateClientinstance had to be created viaNewClientto pass it toBulkIndexerConfig.To improve usability, this change updates the type of
BulkIndexerConfig.Clienttoesapi.Transport, allowing bothClientandTypedClientto be passed directly.